public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper
Date: Tue, 03 Mar 2026 13:29:38 +1000	[thread overview]
Message-ID: <review-patch2-20260302-dmemcg-aggressive-protect-v5-2-ffd3a2602309@gmx.de> (raw)
In-Reply-To: <20260302-dmemcg-aggressive-protect-v5-2-ffd3a2602309@gmx.de>

Patch Review

**Purpose:** Adds `cgroup_common_ancestor()` (generic cgroup helper) and `dmem_cgroup_common_ancestor()` (dmem-specific wrapper), plus refactors `get_cg_pool_unlocked()` into a lookup-only `find_cg_pool_unlocked()`.

**Bug — doc comment copy-paste error:**
```c
/**
 * dmem_cgroup_common_ancestor(): Find the first common ancestor of two pools.
 * @a: First pool to find the common ancestor of.
 * @b: First pool to find the common ancestor of.
```
`@b` should say **"Second pool"**, not "First pool."

**`cgroup_common_ancestor()` correctness:** The algorithm is correct — walking from `min(a->level, b->level)` down to 0, comparing the `ancestors[]` arrays. Since all cgroups in the same hierarchy share the root at level 0, this will always find an ancestor (never return NULL) for cgroups in the same subsystem.

**Reference counting concern:** `dmem_cgroup_common_ancestor()` calls `find_cg_pool_unlocked()` which performs an RCU lookup. If this returns a pool pointer without grabbing a reference, then patch 6's `dmem_cgroup_pool_state_put(ancestor)` would be unbalanced. The diff context doesn't show enough of the original `get_cg_pool_unlocked()` to confirm whether `find_cg_pool_unlocked()` grabs a `css_tryget()` reference. Please verify that `find_cg_pool_unlocked()` returns a properly referenced pool, or add explicit reference counting in `dmem_cgroup_common_ancestor()`.

The refactoring of `get_cg_pool_unlocked()` into `find_cg_pool_unlocked()` + `get_cg_pool_unlocked()` is clean — the "find" variant does the lookup without allocation, and the "get" variant retains the allocate-on-miss behavior.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-03  3:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 12:37 [PATCH v5 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-03-02 12:37 ` [PATCH v5 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-02 14:38   ` Maarten Lankhorst
2026-03-03  3:29   ` Claude Code Review Bot [this message]
2026-03-02 12:37 ` [PATCH v5 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-03-02 15:08   ` Tvrtko Ursulin
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-03-02 15:25   ` Tvrtko Ursulin
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-03-02 17:02   ` Tvrtko Ursulin
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-03-02 12:37 ` [PATCH v5 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot
2026-03-03  3:29 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-13 11:39 [PATCH v6 0/6] " Natalie Vock
2026-03-13 11:40 ` [PATCH v6 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260302-dmemcg-aggressive-protect-v5-2-ffd3a2602309@gmx.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox