From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: vfs: widen inode hash/lookup functions to u64 Date: Wed, 04 Mar 2026 08:15:02 +1000 Message-ID: In-Reply-To: <20260302-iino-u64-v2-2-e5388800dae0@kernel.org> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-2-e5388800dae0@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the most substantive VFS patch. Widening all the inode hash/lookup function signatures from `unsigned long` to `u64` is backward-compatible since `unsigned long` implicitly widens to `u64`. **Minor concern**: The `hash()` function still uses `unsigned long tmp` internally: ```c static unsigned long hash(struct super_block *sb, u64 hashval) { unsigned long tmp; tmp = (hashval * (unsigned long)sb) ^ ... ``` On 32-bit, `hashval` is truncated when multiplied with the 32-bit `(unsigned long)sb`. This is functionally acceptable (hash collisions just go to the same bucket, and full ino comparison happens in the lookup), but a brief comment noting the intentional truncation on 32-bit would be helpful. The `insert_inode_locked()` change from `ino_t ino = inode->i_ino` to `u64 ino = inode->i_ino` is correct -- `ino_t` could be narrower than `u64` on some configurations. The `init_special_inode()` cleanup from `printk(KERN_DEBUG ...)` to `pr_debug(...)` is a nice incidental improvement but slightly outside the strict scope of this series. --- Generated by Claude Code Patch Reviewer