From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: move clock cleanup into Clocks Drop impl
Date: Tue, 03 Mar 2026 12:48:18 +1000
Message-ID: <review-patch2-20260302232500.244489-3-deborah.brouwer@collabora.com>
In-Reply-To: <20260302232500.244489-3-deborah.brouwer@collabora.com>
References: <20260302232500.244489-1-deborah.brouwer@collabora.com> <20260302232500.244489-3-deborah.brouwer@collabora.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Author:** Deborah Brouwer

Moves clock disable/unprepare from `TyrDrmDeviceData::PinnedDrop` into a `Drop` impl on `Clocks` itself. This ensures clocks are disabled last (after other fields that may depend on them are dropped), following Rust's field drop order (fields drop in declaration order).

```rust
+impl Drop for Clocks {
+    fn drop(&mut self) {
+        self.core.disable_unprepare();
+        self.stacks.disable_unprepare();
+        self.coregroup.disable_unprepare();
+    }
+}
```

This is correct because `Clocks` is declared after other fields in `TyrDrmDeviceData`, so it drops last. Also removes `#[pin_data]` from `Clocks` and `Regulators` since they don't need structural pinning.

Clean and well-motivated change.

---
Generated by Claude Code Patch Reviewer