From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge-connector: Switch to using ->detect_ctx hook
Date: Tue, 03 Mar 2026 12:42:54 +1000 [thread overview]
Message-ID: <review-patch2-20260303-dw-hdmi-qp-scramb-v4-2-317d3b8bd219@collabora.com> (raw)
In-Reply-To: <20260303-dw-hdmi-qp-scramb-v4-2-317d3b8bd219@collabora.com>
Patch Review
This patch removes `.detect` from `drm_bridge_connector_funcs` and adds `.detect_ctx` to the helper funcs. The conversion is straightforward.
**Concern about removing .detect:** The old `drm_bridge_connector_detect` was assigned to `drm_connector_funcs.detect`. By removing it entirely, any code path that calls `connector->funcs->detect()` directly (rather than going through the helper framework) will now get a NULL function pointer. The helper framework (`drm_helper_probe_detect_ctx`) checks `detect_ctx` first, so that path works. But `drm_mode_getconnector()` (the ioctl handler) may have a direct `.detect` call path that should be verified. If the ioctl handler also goes through `drm_helper_probe_detect`, this is fine.
The `drm_bridge_connector_get_modes_edid` change is correct:
```c
- status = drm_bridge_connector_detect(connector, false);
+ status = drm_bridge_connector_detect_ctx(connector, NULL, false);
```
When ctx is NULL, `drm_bridge_detect_ctx` manages its own locking and never returns negative values, so assigning to the `enum drm_connector_status status` variable is safe.
**Minor observation:** The `force` parameter from `detect_ctx(connector, ctx, force)` is received but never forwarded to `drm_bridge_detect_ctx`. This is consistent with the bridge-level detect hooks not having a `force` parameter, but it means bridges can never distinguish forced vs. polled detection.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 2:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 1:38 [PATCH v4 0/4] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-03-03 1:38 ` [PATCH v4 1/4] drm/bridge: Add ->detect_ctx hook and drm_bridge_detect_ctx() Cristian Ciocaltea
2026-03-03 2:42 ` Claude review: " Claude Code Review Bot
2026-03-03 1:38 ` [PATCH v4 2/4] drm/bridge-connector: Switch to using ->detect_ctx hook Cristian Ciocaltea
2026-03-03 2:42 ` Claude Code Review Bot [this message]
2026-03-03 1:38 ` [PATCH v4 3/4] drm/bridge: dw-hdmi-qp: Add high TMDS clock ratio and scrambling support Cristian Ciocaltea
2026-03-03 2:42 ` Claude review: " Claude Code Review Bot
2026-03-03 1:38 ` [PATCH v4 4/4] drm/rockchip: dw_hdmi_qp: Do not send HPD events for all connectors Cristian Ciocaltea
2026-03-03 2:42 ` Claude review: " Claude Code Review Bot
2026-03-03 2:42 ` Claude review: Add HDMI 2.0 support to DW HDMI QP TX Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 17:45 [PATCH RESEND v4 0/4] " Cristian Ciocaltea
2026-03-23 17:45 ` [PATCH RESEND v4 2/4] drm/bridge-connector: Switch to using ->detect_ctx hook Cristian Ciocaltea
2026-03-24 21:36 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260303-dw-hdmi-qp-scramb-v4-2-317d3b8bd219@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox