From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fpga: dfl-pci: set driver flag to disable SR-IOV on remove() Date: Wed, 04 Mar 2026 08:40:15 +1000 Message-ID: In-Reply-To: <20260303-rust-pci-sriov-v3-2-4443c35f0c88@redhat.com> References: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> <20260303-rust-pci-sriov-v3-2-4443c35f0c88@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean conversion. The explicit `cci_pci_sriov_configure(pcidev, 0)` call in= `cci_pci_remove()` is correctly removed since the framework now handles it= . Inlining `cci_remove_feature_devs()` into `cci_pci_remove()` is reasonabl= e since the function was a trivial wrapper. **One observation**: The old code guarded the disable call with `dev_is_pf(= )`, while the framework's `pci_iov_disable()` checks `dev->is_physfn` =E2= =80=94 these are equivalent, so the behavior is preserved. --- Generated by Claude Code Patch Reviewer