From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Update log for 'none' recovery method
Date: Wed, 04 Mar 2026 07:31:27 +1000 [thread overview]
Message-ID: <review-patch2-20260303110556.3577612-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20260303110556.3577612-3-raag.jadav@intel.com>
Patch Review
The change:
```c
- "but recovered through reset" : "needs recovery");
+ "but no recovery needed" : "needs recovery");
```
**Concern: loss of diagnostic information.** The old message "but recovered through reset" was informative - it told you the device had already been reset. The new message "but no recovery needed" is vague and covers two very different situations: (a) the device was reset and is healthy, and (b) the device is permanently wedged for debugging. A kernel log reader seeing "device wedged, but no recovery needed" when the device is actually permanently non-functional would find this confusing.
**Suggestion:** Consider making the log more descriptive for the debug case. For instance, in the xe driver, the log at `xe_device.c:1312-1316` already says "CRITICAL: Xe has declared device ... as wedged. IOCTLs and executions are blocked." so there is some context, but the DRM core log is still misleading. At minimum, consider something like "no recovery expected" rather than "no recovery needed" to avoid implying the device is fine.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-03 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 11:05 [PATCH v1 0/3] Update 'none' recovery method for DRM wedged event Raag Jadav
2026-03-03 11:05 ` [PATCH v1 1/3] drm/doc: Update documentation for 'none' recovery method Raag Jadav
2026-03-03 15:32 ` Rodrigo Vivi
2026-03-03 21:31 ` Claude review: " Claude Code Review Bot
2026-03-03 11:05 ` [PATCH v1 2/3] drm: Update log " Raag Jadav
2026-03-03 15:33 ` Rodrigo Vivi
2026-03-03 21:31 ` Claude Code Review Bot [this message]
2026-03-03 11:05 ` [PATCH v1 3/3] drm/xe: Send 'none' recovery method for XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET Raag Jadav
2026-03-03 15:34 ` Rodrigo Vivi
2026-03-03 21:31 ` Claude review: " Claude Code Review Bot
2026-03-03 21:31 ` Claude review: Update 'none' recovery method for DRM wedged event Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260303110556.3577612-3-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox