From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Update log for 'none' recovery method Date: Wed, 04 Mar 2026 07:31:27 +1000 Message-ID: In-Reply-To: <20260303110556.3577612-3-raag.jadav@intel.com> References: <20260303110556.3577612-1-raag.jadav@intel.com> <20260303110556.3577612-3-raag.jadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The change: ```c - "but recovered through reset" : "needs recovery"); + "but no recovery needed" : "needs recovery"); ``` **Concern: loss of diagnostic information.** The old message "but recovered through reset" was informative - it told you the device had already been reset. The new message "but no recovery needed" is vague and covers two very different situations: (a) the device was reset and is healthy, and (b) the device is permanently wedged for debugging. A kernel log reader seeing "device wedged, but no recovery needed" when the device is actually permanently non-functional would find this confusing. **Suggestion:** Consider making the log more descriptive for the debug case. For instance, in the xe driver, the log at `xe_device.c:1312-1316` already says "CRITICAL: Xe has declared device ... as wedged. IOCTLs and executions are blocked." so there is some context, but the DRM core log is still misleading. At minimum, consider something like "no recovery expected" rather than "no recovery needed" to avoid implying the device is fine. --- Generated by Claude Code Patch Reviewer