public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue
Date: Thu, 05 Mar 2026 13:52:59 +1000	[thread overview]
Message-ID: <review-patch2-20260304-cmdq-locking-v3-2-a6314b708850@nvidia.com> (raw)
In-Reply-To: <20260304-cmdq-locking-v3-2-a6314b708850@nvidia.com>

Patch Review

Extracts the magic `Delta::from_secs(10)` and `Delta::from_secs(5)` values into a single `RECEIVE_TIMEOUT` constant.

One note: the `get_gsp_info` caller previously used a 5-second timeout (`Delta::from_secs(5)`) while the others used 10 seconds:

```rust
-        match cmdq.receive_msg::<GetGspStaticInfoReply>(Delta::from_secs(5)) {
+        match cmdq.receive_msg::<GetGspStaticInfoReply>(Cmdq::RECEIVE_TIMEOUT) {
```

This silently increases the timeout for `get_gsp_info` from 5s to 10s. This is almost certainly fine (a 5s timeout was probably just picked arbitrarily, and 10s is more conservative), but it should be mentioned in the commit message since it's a behavioral change, not just a mechanical refactor.

The visibility `pub(super)` is appropriate.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-05  3:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  2:46 [PATCH v3 0/5] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-03-04  2:46 ` [PATCH v3 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-04 11:25   ` Gary Guo
2026-03-04 11:55     ` Alexandre Courbot
2026-03-05  3:52   ` Claude review: " Claude Code Review Bot
2026-03-04  2:46 ` [PATCH v3 2/5] gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Eliot Courtney
2026-03-04 11:25   ` Gary Guo
2026-03-04 11:55   ` Alexandre Courbot
2026-03-05  3:52   ` Claude Code Review Bot [this message]
2026-03-04  2:46 ` [PATCH v3 3/5] gpu: nova-core: gsp: add reply/no-reply info to `CommandToGsp` Eliot Courtney
2026-03-04 11:27   ` Gary Guo
2026-03-04 11:56   ` Alexandre Courbot
2026-03-05  1:34     ` Eliot Courtney
2026-03-05  2:10       ` Alexandre Courbot
2026-03-04 14:17   ` Alexandre Courbot
2026-03-05  1:29     ` Eliot Courtney
2026-03-05  1:37       ` Alexandre Courbot
2026-03-05  3:52   ` Claude review: " Claude Code Review Bot
2026-03-04  2:46 ` [PATCH v3 4/5] gpu: nova-core: gsp: make `Cmdq` a pinned type Eliot Courtney
2026-03-05  3:53   ` Claude review: " Claude Code Review Bot
2026-03-04  2:46 ` [PATCH v3 5/5] gpu: nova-core: gsp: add mutex locking to Cmdq Eliot Courtney
2026-03-04 11:57   ` Alexandre Courbot
2026-03-05  1:36     ` Eliot Courtney
2026-03-05  1:51       ` Alexandre Courbot
2026-03-04 12:02   ` Alexandre Courbot
2026-03-05  3:53   ` Claude review: " Claude Code Review Bot
2026-03-04 11:58 ` [PATCH v3 0/5] gpu: nova-core: gsp: add " Alexandre Courbot
2026-03-05  3:52 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  8:09 [PATCH v4 0/5] " Eliot Courtney
2026-03-10  8:09 ` [PATCH v4 2/5] gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Eliot Courtney
2026-03-11  3:32   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260304-cmdq-locking-v3-2-a6314b708850@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox