From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Date: Thu, 05 Mar 2026 13:52:59 +1000 Message-ID: In-Reply-To: <20260304-cmdq-locking-v3-2-a6314b708850@nvidia.com> References: <20260304-cmdq-locking-v3-0-a6314b708850@nvidia.com> <20260304-cmdq-locking-v3-2-a6314b708850@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Extracts the magic `Delta::from_secs(10)` and `Delta::from_secs(5)` values into a single `RECEIVE_TIMEOUT` constant. One note: the `get_gsp_info` caller previously used a 5-second timeout (`Delta::from_secs(5)`) while the others used 10 seconds: ```rust - match cmdq.receive_msg::(Delta::from_secs(5)) { + match cmdq.receive_msg::(Cmdq::RECEIVE_TIMEOUT) { ``` This silently increases the timeout for `get_gsp_info` from 5s to 10s. This is almost certainly fine (a 5s timeout was probably just picked arbitrarily, and 10s is more conservative), but it should be mentioned in the commit message since it's a behavioral change, not just a mechanical refactor. The visibility `pub(super)` is appropriate. --- Generated by Claude Code Patch Reviewer