From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: aux: Add drm_aux_bridge_register_from_node() Date: Thu, 05 Mar 2026 13:37:59 +1000 Message-ID: In-Reply-To: <20260304094152.92-3-kernel@airkyi.com> References: <20260304094152.92-1-kernel@airkyi.com> <20260304094152.92-3-kernel@airkyi.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean refactoring. The existing `drm_aux_bridge_register()` becomes a thin wrapper. **Issue (minor): Doc comment on original function was modified incorrectly.** The `@np` parameter was added to the doc comment for `drm_aux_bridge_register()` before the function was renamed: ```c /** * drm_aux_bridge_register - Create a simple bridge device to link the chain * @parent: device instance providing this bridge * @np: device node pointer corresponding to this bridge instance ``` But the function being documented is now `drm_aux_bridge_register_from_node()`, so this is technically fine, but the description text ("Create a simple bridge device to link the chain") doesn't mention the `np` override behavior. A note in the description about specifying a custom of_node would help. No functional concerns. Reviewed-by from Neil Armstrong. --- Generated by Claude Code Patch Reviewer