public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: Test for fbdev GEM object with generic helper
Date: Thu, 05 Mar 2026 13:27:24 +1000	[thread overview]
Message-ID: <review-patch2-20260304130250.59008-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20260304130250.59008-3-tzimmermann@suse.de>

Patch Review

**Overall**: Straightforward conversion. Removes radeon's `radeon_fbdev_robj_is_fb()` and replaces its call site with `drm_fb_helper_gem_is_fb()`.

**Correct conversion**: The original radeon code used `drm_gem_fb_get_obj(fb_helper->fb, 0)` directly, while the new helper covers this via the `else if (fb_helper->fb)` branch. The behavior is preserved.

**Same scoping improvement** as patch 1 — `robj` moves into the block where it's needed:

```c
-		robj = gem_to_radeon_bo(fb->obj[0]);
 		/* don't unpin kernel fb objects */
-		if (!radeon_fbdev_robj_is_fb(rdev, robj)) {
+		if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
+			struct radeon_bo *robj = gem_to_radeon_bo(fb->obj[0]);
```

**Clean removal**: Both the implementation in `radeon_fbdev.c` and the declaration + static inline stub in `radeon_mode.h` are properly removed.

**Summary of actionable items**:
1. Change `EXPORT_SYMBOL_GPL` to `EXPORT_SYMBOL` for consistency with the rest of `drm_fb_helper.c`.
2. Fix typo: "test is" → "test if" in the kdoc comment.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-05  3:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 12:58 [PATCH 0/2] amdgpu,radeon: Test fbdev GEM object in helper Thomas Zimmermann
2026-03-04 12:58 ` [PATCH 1/2] drm/amdgpu: Move test for fbdev GEM object into generic helper Thomas Zimmermann
2026-03-05  3:27   ` Claude review: " Claude Code Review Bot
2026-03-04 12:58 ` [PATCH 2/2] drm/radeon: Test for fbdev GEM object with " Thomas Zimmermann
2026-03-04 15:32   ` Alex Deucher
2026-03-04 15:49     ` Thomas Zimmermann
2026-03-05  3:27   ` Claude Code Review Bot [this message]
2026-03-05  3:27 ` Claude review: amdgpu,radeon: Test fbdev GEM object in helper Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260304130250.59008-3-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox