From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/radeon: Test for fbdev GEM object with generic helper Date: Thu, 05 Mar 2026 13:27:24 +1000 Message-ID: In-Reply-To: <20260304130250.59008-3-tzimmermann@suse.de> References: <20260304130250.59008-1-tzimmermann@suse.de> <20260304130250.59008-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall**: Straightforward conversion. Removes radeon's `radeon_fbdev_rob= j_is_fb()` and replaces its call site with `drm_fb_helper_gem_is_fb()`. **Correct conversion**: The original radeon code used `drm_gem_fb_get_obj(f= b_helper->fb, 0)` directly, while the new helper covers this via the `else = if (fb_helper->fb)` branch. The behavior is preserved. **Same scoping improvement** as patch 1 =E2=80=94 `robj` moves into the blo= ck where it's needed: ```c - robj =3D gem_to_radeon_bo(fb->obj[0]); /* don't unpin kernel fb objects */ - if (!radeon_fbdev_robj_is_fb(rdev, robj)) { + if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { + struct radeon_bo *robj =3D gem_to_radeon_bo(fb->obj[0]); ``` **Clean removal**: Both the implementation in `radeon_fbdev.c` and the decl= aration + static inline stub in `radeon_mode.h` are properly removed. **Summary of actionable items**: 1. Change `EXPORT_SYMBOL_GPL` to `EXPORT_SYMBOL` for consistency with the r= est of `drm_fb_helper.c`. 2. Fix typo: "test is" =E2=86=92 "test if" in the kdoc comment. --- Generated by Claude Code Patch Reviewer