From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panfrost: Drop redundant optional clock checks in runtime PM Date: Thu, 05 Mar 2026 13:22:27 +1000 Message-ID: In-Reply-To: <20260304134845.267030-3-biju.das.jz@bp.renesas.com> References: <20260304134845.267030-1-biju.das.jz@bp.renesas.com> <20260304134845.267030-3-biju.das.jz@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch removes the `if (pfdev->bus_clock)` guards around `clk_enable()`/`clk_disable()` calls in the runtime PM paths. The commit message correctly notes that the clk API handles NULL pointers gracefully. **Looks correct.** This is a straightforward cleanup. The `clk_enable()` and `clk_disable()` APIs are indeed NULL-safe. Removing the guards simplifies the code and makes Patch 3 cleaner. --- Generated by Claude Code Patch Reviewer