public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/v3d: Use raw seqcount helpers instead of fighting with lockdep
Date: Mon, 09 Mar 2026 09:20:15 +1000	[thread overview]
Message-ID: <review-patch2-20260305-v3d-reset-locking-improv-v2-2-fd53c91f7726@igalia.com> (raw)
In-Reply-To: <20260305-v3d-reset-locking-improv-v2-2-fd53c91f7726@igalia.com>

Patch Review

The switch to `raw_write_seqcount_begin/end` and `raw_read_seqcount_begin` is justified by the commit message — jobs are serialized per queue, so there's no real race, and the lockdep annotations were producing false positives.

Minor nit: The read side changes `read_seqcount_begin` to `raw_read_seqcount_begin` but leaves `read_seqcount_retry` unchanged:

```c
	do {
		seq = raw_read_seqcount_begin(&stats->lock);
		...
	} while (read_seqcount_retry(&stats->lock, seq));
```

This is functionally correct since the lockdep annotation is on the `begin` side, not the `retry` side (which only has KCSAN annotations). But for consistency, you might consider whether pairing with `raw_read_seqcount_retry` (if available) would be cleaner.

The removal of the `IS_ENABLED(CONFIG_LOCKDEP)` conditional IRQ save/restore significantly simplifies the code. The comment in `v3d_drv.h` explaining why raw helpers are used is helpful.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 23:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 23:25 [PATCH v2 0/6] drm/v3d: Improve v3d_stats lifetime and locking Maíra Canal
2026-03-05 23:25 ` [PATCH v2 1/6] drm/v3d: Handle error from drm_sched_entity_init() Maíra Canal
2026-03-08 23:20   ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 2/6] drm/v3d: Use raw seqcount helpers instead of fighting with lockdep Maíra Canal
2026-03-08 23:20   ` Claude Code Review Bot [this message]
2026-03-05 23:25 ` [PATCH v2 3/6] drm/v3d: Refcount v3d_stats Maíra Canal
2026-03-08 23:20   ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 4/6] drm/v3d: Hold v3d_stats references in each job Maíra Canal
2026-03-08 23:20   ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 5/6] drm/v3d: Attach per-fd reset counters to v3d_stats Maíra Canal
2026-03-08 23:20   ` Claude review: " Claude Code Review Bot
2026-03-05 23:25 ` [PATCH v2 6/6] drm/v3d: Remove dedicated fence_lock Maíra Canal
2026-03-08 23:20   ` Claude review: " Claude Code Review Bot
2026-03-08 23:20 ` Claude review: drm/v3d: Improve v3d_stats lifetime and locking Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-06 11:30 [PATCH v3 0/6] " Maíra Canal
2026-03-06 11:30 ` [PATCH v3 2/6] drm/v3d: Use raw seqcount helpers instead of fighting with lockdep Maíra Canal
2026-03-08 22:56   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260305-v3d-reset-locking-improv-v2-2-fd53c91f7726@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox