From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Use raw seqcount helpers instead of fighting with lockdep Date: Mon, 09 Mar 2026 09:20:15 +1000 Message-ID: In-Reply-To: <20260305-v3d-reset-locking-improv-v2-2-fd53c91f7726@igalia.com> References: <20260305-v3d-reset-locking-improv-v2-0-fd53c91f7726@igalia.com> <20260305-v3d-reset-locking-improv-v2-2-fd53c91f7726@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The switch to `raw_write_seqcount_begin/end` and `raw_read_seqcount_begin` = is justified by the commit message =E2=80=94 jobs are serialized per queue,= so there's no real race, and the lockdep annotations were producing false = positives. Minor nit: The read side changes `read_seqcount_begin` to `raw_read_seqcoun= t_begin` but leaves `read_seqcount_retry` unchanged: ```c do { seq =3D raw_read_seqcount_begin(&stats->lock); ... } while (read_seqcount_retry(&stats->lock, seq)); ``` This is functionally correct since the lockdep annotation is on the `begin`= side, not the `retry` side (which only has KCSAN annotations). But for con= sistency, you might consider whether pairing with `raw_read_seqcount_retry`= (if available) would be cleaner. The removal of the `IS_ENABLED(CONFIG_LOCKDEP)` conditional IRQ save/restor= e significantly simplifies the code. The comment in `v3d_drv.h` explaining = why raw helpers are used is helpful. --- Generated by Claude Code Patch Reviewer