public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: innolux,p097pfg: Document ports
Date: Mon, 09 Mar 2026 08:53:19 +1000	[thread overview]
Message-ID: <review-patch2-20260306-dt-bindings-display-panel-clean-v1-2-3086eda1efaf@oss.qualcomm.com> (raw)
In-Reply-To: <20260306-dt-bindings-display-panel-clean-v1-2-3086eda1efaf@oss.qualcomm.com>

Patch Review

Changes the `$ref` from `panel-common.yaml#` to `panel-common-dual.yaml#` and adds `port: true` / `ports: true` with a dual-port example. This is correct because:

- `panel-common-dual.yaml` extends `panel-common.yaml` with dual-link `ports` support
- The `p097pfg` is a dual-channel MIPI-DSI panel (confirmed by the two-port example with `port@0` and `port@1`)
- The commit message notes this is "already used like this in DTS"

The example with two ports (`mipi_in_panel` / `mipi1_in_panel`) is correctly structured. No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 22:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 1/5] dt-bindings: display: samsung,s6d7aa0: Document port Krzysztof Kozlowski
2026-03-08 22:53   ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports Krzysztof Kozlowski
2026-03-08 22:53   ` Claude Code Review Bot [this message]
2026-03-06 12:02 ` [PATCH 3/5] dt-bindings: display: panel: Drop redundant properties Krzysztof Kozlowski
2026-03-08 22:53   ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 4/5] dt-bindings: display: panel: Align style of additionalProperties Krzysztof Kozlowski
2026-03-08 22:53   ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-08 22:53   ` Claude review: " Claude Code Review Bot
2026-03-08 22:53 ` Claude review: dt-bindings: display: panel: Few cleanups and fixes Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260306-dt-bindings-display-panel-clean-v1-2-3086eda1efaf@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox