public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: bus: mhi: Move sahara protocol driver under drivers/bus/mhi
Date: Mon, 09 Mar 2026 08:09:00 +1000	[thread overview]
Message-ID: <review-patch2-20260307-sahara_protocol_new_v2-v2-2-29dc748b5e9c@oss.qualcomm.com> (raw)
In-Reply-To: <20260307-sahara_protocol_new_v2-v2-2-29dc748b5e9c@oss.qualcomm.com>

Patch Review

The core move of `sahara.c` and `sahara.h` is straightforward.

- **Copyright/license regression:**
  ```
  -// SPDX-License-Identifier: GPL-2.0-only
  -
  -/* Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. */
  +// SPDX-License-Identifier: GPL-2.0
  +/*
  + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.
  + *
  + */
  ```
  Changing from `GPL-2.0-only` to `GPL-2.0` is a license change. The copyright was updated in the existing code to 2024/QIC; reverting it to 2018-2020/TLF looks wrong.

- **Error handling regression in qaic_drv.c:**
  ```c
   	ret = pci_register_driver(&qaic_pci_driver);
   	if (ret) {
   		pr_debug("qaic: pci_register_driver failed %d\n", ret);
  -		return ret;
  +		goto free_pci;
   	}
  ```
  On `pci_register_driver` failure, this now jumps to `free_pci` which calls `pci_unregister_driver` -- unregistering a driver that was never successfully registered. The original `return ret` was correct.

- **`sahara.h` moved to `include/linux/sahara.h`** but it only contains `sahara_register()` and `sahara_unregister()` declarations, which are no longer needed since sahara is now a standalone module using `module_init`/`module_exit`. The header should either be removed or have its contents updated to reflect the new interface (if any).

- **Kconfig selects `FW_LOADER_COMPRESS`, `FW_LOADER_COMPRESS_XZ`, and `FW_LOADER_COMPRESS_ZSTD`** -- are all three compression formats actually needed? This seems excessive for a protocol driver. If the firmware files don't use both XZ and ZSTD, only select what's needed.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-08 22:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 11:41 [PATCH v2 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-07 11:41 ` [PATCH v2 1/9] Add documentation for Sahara protocol Kishore Batta
2026-03-07 19:50   ` kernel test robot
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-08 22:09   ` Claude Code Review Bot [this message]
2026-03-07 11:41 ` [PATCH v2 3/9] bus: mhi: Match devices exposing the protocol on the SAHARA channel Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 4/9] bus: mhi: Centralize firmware image table selection at probe time Kishore Batta
2026-03-08  8:56   ` kernel test robot
2026-03-08  9:27   ` kernel test robot
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 5/9] bus: mhi: Add QDU100 firmware image table Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 6/9] bus: mhi: Load DDR training data using per-device serial number Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 7/9] bus: mhi: Capture DDR training data using command mode Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 8/9] bus: mhi: Expose DDR training data via controller sysfs Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-07 11:41 ` [PATCH v2 9/9] Documentation: ABI: Add sysfs ABI documentation for DDR training data Kishore Batta
2026-03-08 22:09   ` Claude review: " Claude Code Review Bot
2026-03-08 22:08 ` Claude review: Qualcomm Sahara protocol enhancements Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-10  7:21 [PATCH v3 0/9] " Kishore Batta
2026-03-10  7:21 ` [PATCH v3 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-11  3:35   ` Claude review: " Claude Code Review Bot
2026-03-19  6:31 [PATCH v4 0/9] Qualcomm Sahara protocol enhancements Kishore Batta
2026-03-19  6:31 ` [PATCH v4 2/9] bus: mhi: Move sahara protocol driver under drivers/bus/mhi Kishore Batta
2026-03-21 18:44   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260307-sahara_protocol_new_v2-v2-2-29dc748b5e9c@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox