From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Move sahara protocol driver under drivers/bus/mhi Date: Mon, 09 Mar 2026 08:09:00 +1000 Message-ID: In-Reply-To: <20260307-sahara_protocol_new_v2-v2-2-29dc748b5e9c@oss.qualcomm.com> References: <20260307-sahara_protocol_new_v2-v2-0-29dc748b5e9c@oss.qualcomm.com> <20260307-sahara_protocol_new_v2-v2-2-29dc748b5e9c@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The core move of `sahara.c` and `sahara.h` is straightforward. - **Copyright/license regression:** ``` -// SPDX-License-Identifier: GPL-2.0-only - -/* Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved. */ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. + * + */ ``` Changing from `GPL-2.0-only` to `GPL-2.0` is a license change. The copyright was updated in the existing code to 2024/QIC; reverting it to 2018-2020/TLF looks wrong. - **Error handling regression in qaic_drv.c:** ```c ret = pci_register_driver(&qaic_pci_driver); if (ret) { pr_debug("qaic: pci_register_driver failed %d\n", ret); - return ret; + goto free_pci; } ``` On `pci_register_driver` failure, this now jumps to `free_pci` which calls `pci_unregister_driver` -- unregistering a driver that was never successfully registered. The original `return ret` was correct. - **`sahara.h` moved to `include/linux/sahara.h`** but it only contains `sahara_register()` and `sahara_unregister()` declarations, which are no longer needed since sahara is now a standalone module using `module_init`/`module_exit`. The header should either be removed or have its contents updated to reflect the new interface (if any). - **Kconfig selects `FW_LOADER_COMPRESS`, `FW_LOADER_COMPRESS_XZ`, and `FW_LOADER_COMPRESS_ZSTD`** -- are all three compression formats actually needed? This seems excessive for a protocol driver. If the firmware files don't use both XZ and ZSTD, only select what's needed. --- Generated by Claude Code Patch Reviewer