public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: Add driver for Novatek NT35532
Date: Mon, 09 Mar 2026 07:46:26 +1000	[thread overview]
Message-ID: <review-patch2-20260308-rimob-new-features-v1-2-aa2c330572c0@protonmail.com> (raw)
In-Reply-To: <20260308-rimob-new-features-v1-2-aa2c330572c0@protonmail.com>

Patch Review

**Init sequence uses generic writes for standard DCS commands.** At the end of `nt35532_on()`:

```c
mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x11, 0x00);
mipi_dsi_msleep(&dsi_ctx, 120);
mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x29, 0x00);
mipi_dsi_msleep(&dsi_ctx, 50);
```

`0x11` is `MIPI_DCS_EXIT_SLEEP_MODE` and `0x29` is `MIPI_DCS_SET_DISPLAY_ON`. These should use the proper DCS helpers, consistent with how `nt35532_off()` already uses them:

```c
mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
mipi_dsi_msleep(&dsi_ctx, 120);
mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
mipi_dsi_msleep(&dsi_ctx, 50);
```

This is a common artifact of auto-generated drivers, but reviewers will ask for it to be fixed.

**`#include <drm/drm_probe_helper.h>`** is included for `drm_connector_helper_get_modes_fixed()`. This is correct, but the corresponding `select DRM_KMS_HELPER` in Kconfig may be unnecessary — check whether `DRM_MIPI_DSI` already selects it transitively. Other recent panel drivers don't always add this select.

**Structure and APIs are good:**
- Uses `devm_drm_panel_alloc()` (the modern allocation API) 
- Uses `devm_regulator_bulk_get_const()` with a static supply array
- Uses `mipi_dsi_multi_context` for the init sequence
- Uses `drm_connector_helper_get_modes_fixed()` for mode reporting
- `prepare_prev_first = true` is set correctly

**Reset sequence looks correct** given `GPIO_ACTIVE_LOW` in the DTS:

```c
gpiod_set_value_cansleep(ctx->reset_gpio, 0);  // de-assert
usleep_range(10000, 11000);
gpiod_set_value_cansleep(ctx->reset_gpio, 1);  // assert (reset pulse)
usleep_range(5000, 6000);
gpiod_set_value_cansleep(ctx->reset_gpio, 0);  // de-assert
usleep_range(10000, 11000);
```

**Minor:** The `MODULE_AUTHOR()` macro is missing. Not strictly required but conventional.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-08 21:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-08 15:52 [PATCH 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-08 15:52 ` [PATCH 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-08 16:13   ` Krzysztof Kozlowski
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-08 19:27   ` Dmitry Baryshkov
2026-03-08 21:46   ` Claude Code Review Bot [this message]
2026-03-08 15:52 ` [PATCH 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-08 15:01   ` Dmitry Baryshkov
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 4/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable WiFi/Bluetooth Cristian Cozzolino via B4 Relay
2026-03-08 15:08   ` Dmitry Baryshkov
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Cristian Cozzolino via B4 Relay
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot
2026-03-08 15:52 ` [PATCH 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-08 15:14   ` Dmitry Baryshkov
2026-03-08 21:46   ` Claude review: " Claude Code Review Bot
2026-03-08 21:46 ` Claude review: Enable new features for flipkart-rimob Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-18 22:28 [PATCH v2 0/6] " Cristian Cozzolino via B4 Relay
2026-03-18 22:28 ` [PATCH v2 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-21 16:23 [PATCH v3 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-21 16:23 ` [PATCH v3 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-21 17:00   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260308-rimob-new-features-v1-2-aa2c330572c0@protonmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox