From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: dsi: re-add clear enable register if DSI was powered by bootloader
Date: Tue, 10 Mar 2026 12:38:59 +1000 [thread overview]
Message-ID: <review-patch2-20260309075248.47730-3-clamor95@gmail.com> (raw)
In-Reply-To: <20260309075248.47730-3-clamor95@gmail.com>
Patch Review
**Correct fix, well-reasoned.**
The placement after `tegra_dsi_prepare()` (which resumes the host1x client, enables MIPI, and calibrates pads) ensures the hardware is initialized before doing any register reads. This solves the original hang where DSI registers were accessed before the hardware was powered up.
**Minor issues:**
1. **Comment style violation:** The comment at `dsi.c:938-941` does not follow kernel multi-line comment style:
```c
/* If the bootloader enabled DSI it needs to be disabled
* in order for the panel initialization commands to be
* properly sent.
*/
```
Per kernel coding style, the opening `/*` should be on its own line for multi-line comments:
```c
/*
* If the bootloader enabled DSI it needs to be disabled
* in order for the panel initialization commands to be
* properly sent.
*/
```
2. **Ganged mode consideration:** When `tegra_dsi_disable()` is called and `dsi->slave` is set, it will also disable the slave DSI and call `tegra_dsi_ganged_disable()`. This should be fine since the bootloader would have configured ganged mode if applicable, and we want to fully reset the state regardless.
3. **Missing Fixes tag consideration:** The `Fixes:` tags reference both the original commit and its revert. This is correct since the patch effectively supersedes both.
**No blocking issues.** Already has Reviewed-by from Mikko Perttunen. The only actionable item is the comment style nit (should use `/*` on its own line for multi-line comments).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-10 2:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 7:52 [PATCH v4 0/2] gpu/drm: tegra: add DSI support for Tegra20/Tegra30 Svyatoslav Ryhel
2026-03-09 7:52 ` [PATCH v4 1/2] drm/tegra: dsi: add " Svyatoslav Ryhel
2026-03-10 2:38 ` Claude review: " Claude Code Review Bot
2026-03-09 7:52 ` [PATCH v4 2/2] drm/tegra: dsi: re-add clear enable register if DSI was powered by bootloader Svyatoslav Ryhel
2026-03-10 2:38 ` Claude Code Review Bot [this message]
2026-03-10 2:38 ` Claude review: gpu/drm: tegra: add DSI support for Tegra20/Tegra30 Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260309075248.47730-3-clamor95@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox