From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: dsi: re-add clear enable register if DSI was powered by bootloader
Date: Tue, 10 Mar 2026 12:38:59 +1000
Message-ID: <review-patch2-20260309075248.47730-3-clamor95@gmail.com>
In-Reply-To: <20260309075248.47730-3-clamor95@gmail.com>
References: <20260309075248.47730-1-clamor95@gmail.com> <20260309075248.47730-3-clamor95@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Correct fix, well-reasoned.**

The placement after `tegra_dsi_prepare()` (which resumes the host1x client, enables MIPI, and calibrates pads) ensures the hardware is initialized before doing any register reads. This solves the original hang where DSI registers were accessed before the hardware was powered up.

**Minor issues:**

1. **Comment style violation:** The comment at `dsi.c:938-941` does not follow kernel multi-line comment style:
   ```c
   /* If the bootloader enabled DSI it needs to be disabled
    * in order for the panel initialization commands to be
    * properly sent.
    */
   ```
   Per kernel coding style, the opening `/*` should be on its own line for multi-line comments:
   ```c
   /*
    * If the bootloader enabled DSI it needs to be disabled
    * in order for the panel initialization commands to be
    * properly sent.
    */
   ```

2. **Ganged mode consideration:** When `tegra_dsi_disable()` is called and `dsi->slave` is set, it will also disable the slave DSI and call `tegra_dsi_ganged_disable()`. This should be fine since the bootloader would have configured ganged mode if applicable, and we want to fully reset the state regardless.

3. **Missing Fixes tag consideration:** The `Fixes:` tags reference both the original commit and its revert. This is correct since the patch effectively supersedes both.

**No blocking issues.** Already has Reviewed-by from Mikko Perttunen. The only actionable item is the comment style nit (should use `/*` on its own line for multi-line comments).

---
Generated by Claude Code Patch Reviewer