From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: Clear CMA highages using helper
Date: Wed, 11 Mar 2026 13:29:33 +1000 [thread overview]
Message-ID: <review-patch2-20260310-cma-heap-clear-pages-v2-2-ecbbed3d7e6d@kernel.org> (raw)
In-Reply-To: <20260310-cma-heap-clear-pages-v2-2-ecbbed3d7e6d@kernel.org>
Patch Review
**Typo in subject:** "highages" should be "highpages". This appears in both the cover letter (`Clear CMA highages using helper`) and the patch subject. Worth fixing in the next revision.
**Change:** Replaces the open-coded `kmap_local_page()` / `clear_page()` / `kunmap_local()` sequence with a single `clear_highpage(page)` call. Looking at the existing code at `cma_heap.c:331-335`:
```c
void *vaddr = kmap_local_page(page);
clear_page(vaddr);
kunmap_local(vaddr);
```
This is exactly what `clear_highpage()` does, so the substitution is correct and simplifies the code nicely. The surrounding loop logic (fatal signal check, page increment, counter decrement) is properly preserved.
**Overall:** Both patches are simple, correct cleanups. The only actionable item is the "highages" typo in the patch 2 subject line — should be "highpages".
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 8:53 [PATCH v2 0/2] dma-buf: heaps: Use page clearing helpers Linus Walleij
2026-03-10 8:53 ` [PATCH v2 1/2] dma-buf: heaps: Clear CMA pages with clear_pages() Linus Walleij
2026-03-10 15:29 ` T.J. Mercier
2026-03-11 3:29 ` Claude review: " Claude Code Review Bot
2026-03-10 8:53 ` [PATCH v2 2/2] dma-buf: heaps: Clear CMA highages using helper Linus Walleij
2026-03-10 8:55 ` Christian König
2026-03-10 15:29 ` T.J. Mercier
2026-03-11 3:29 ` Claude Code Review Bot [this message]
2026-03-10 14:30 ` [PATCH v2 0/2] dma-buf: heaps: Use page clearing helpers Maxime Ripard
2026-03-11 3:29 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260310-cma-heap-clear-pages-v2-2-ecbbed3d7e6d@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox