From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: heaps: Clear CMA highages using helper Date: Wed, 11 Mar 2026 13:29:33 +1000 Message-ID: In-Reply-To: <20260310-cma-heap-clear-pages-v2-2-ecbbed3d7e6d@kernel.org> References: <20260310-cma-heap-clear-pages-v2-0-ecbbed3d7e6d@kernel.org> <20260310-cma-heap-clear-pages-v2-2-ecbbed3d7e6d@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Typo in subject:** "highages" should be "highpages". This appears in both= the cover letter (`Clear CMA highages using helper`) and the patch subject= . Worth fixing in the next revision. **Change:** Replaces the open-coded `kmap_local_page()` / `clear_page()` / = `kunmap_local()` sequence with a single `clear_highpage(page)` call. Lookin= g at the existing code at `cma_heap.c:331-335`: ```c void *vaddr =3D kmap_local_page(page); clear_page(vaddr); kunmap_local(vaddr); ``` This is exactly what `clear_highpage()` does, so the substitution is correc= t and simplifies the code nicely. The surrounding loop logic (fatal signal = check, page increment, counter decrement) is properly preserved. **Overall:** Both patches are simple, correct cleanups. The only actionable= item is the "highages" typo in the patch 2 subject line =E2=80=94 should b= e "highpages". --- Generated by Claude Code Patch Reviewer