From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue
Date: Wed, 11 Mar 2026 13:32:09 +1000 [thread overview]
Message-ID: <review-patch2-20260310-cmdq-locking-v4-2-4e5c4753c408@nvidia.com> (raw)
In-Reply-To: <20260310-cmdq-locking-v4-2-4e5c4753c408@nvidia.com>
Patch Review
Straightforward extraction of magic timeout values into a named constant:
```rust
+ pub(super) const RECEIVE_TIMEOUT: Delta = Delta::from_secs(5);
```
The previous code used `Delta::from_secs(10)` in two places and `Delta::from_secs(5)` in one place. This patch unifies all three to 5 seconds (per the v4 changelog). The `wait_gsp_init_done` and `GspSequencer::run` callers were previously using 10s timeouts; reducing them to 5s is a behavioral change. Given the cover letter mentions GSP is expected to be fast and v4 explicitly changed this from 10s to 5s, this seems intentional and reasonable.
The visibility `pub(super)` is appropriate since it's used across sibling modules within `gsp/`.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 8:09 [PATCH v4 0/5] gpu: nova-core: gsp: add locking to Cmdq Eliot Courtney
2026-03-10 8:09 ` [PATCH v4 1/5] gpu: nova-core: gsp: fix stale doc comments on command queue methods Eliot Courtney
2026-03-11 3:32 ` Claude review: " Claude Code Review Bot
2026-03-10 8:09 ` [PATCH v4 2/5] gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Eliot Courtney
2026-03-11 3:32 ` Claude Code Review Bot [this message]
2026-03-10 8:09 ` [PATCH v4 3/5] gpu: nova-core: gsp: add reply/no-reply info to `CommandToGsp` Eliot Courtney
2026-03-11 3:32 ` Claude review: " Claude Code Review Bot
2026-03-10 8:09 ` [PATCH v4 4/5] gpu: nova-core: gsp: make `Cmdq` a pinned type Eliot Courtney
2026-03-11 3:32 ` Claude review: " Claude Code Review Bot
2026-03-10 8:09 ` [PATCH v4 5/5] gpu: nova-core: gsp: add mutex locking to Cmdq Eliot Courtney
2026-03-11 3:32 ` Claude review: " Claude Code Review Bot
2026-03-11 3:32 ` Claude review: gpu: nova-core: gsp: add " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 2:46 [PATCH v3 0/5] " Eliot Courtney
2026-03-04 2:46 ` [PATCH v3 2/5] gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Eliot Courtney
2026-03-05 3:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260310-cmdq-locking-v4-2-4e5c4753c408@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox