From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: add `RECEIVE_TIMEOUT` constant for command queue Date: Wed, 11 Mar 2026 13:32:09 +1000 Message-ID: In-Reply-To: <20260310-cmdq-locking-v4-2-4e5c4753c408@nvidia.com> References: <20260310-cmdq-locking-v4-0-4e5c4753c408@nvidia.com> <20260310-cmdq-locking-v4-2-4e5c4753c408@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Straightforward extraction of magic timeout values into a named constant: ```rust + pub(super) const RECEIVE_TIMEOUT: Delta = Delta::from_secs(5); ``` The previous code used `Delta::from_secs(10)` in two places and `Delta::from_secs(5)` in one place. This patch unifies all three to 5 seconds (per the v4 changelog). The `wait_gsp_init_done` and `GspSequencer::run` callers were previously using 10s timeouts; reducing them to 5s is a behavioral change. Given the cover letter mentions GSP is expected to be fast and v4 explicitly changed this from 10s to 5s, this seems intentional and reasonable. The visibility `pub(super)` is appropriate since it's used across sibling modules within `gsp/`. No issues. --- Generated by Claude Code Patch Reviewer