public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: samsung-dsim: use drm_bridge_clear_and_put() to put the next bridge
Date: Wed, 11 Mar 2026 13:16:32 +1000	[thread overview]
Message-ID: <review-patch2-20260310-drm-bridge-atomic-vs-remove-clear_and_put-v2-2-51fe222f3cf0@bootlin.com> (raw)
In-Reply-To: <20260310-drm-bridge-atomic-vs-remove-clear_and_put-v2-2-51fe222f3cf0@bootlin.com>

Patch Review

**Code review**:

The conversion is mechanical and correct. In `samsung_dsim_host_attach` error path (`drivers/gpu/drm/bridge/samsung-dsim.c:1991`):
```c
err_release_next_bridge:
	drm_bridge_clear_and_put(&dsi->bridge.next_bridge);
	if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO))
```

And in `samsung_dsim_host_detach` (`drivers/gpu/drm/bridge/samsung-dsim.c:2008`):
```c
	drm_bridge_clear_and_put(&dsi->bridge.next_bridge);
```

Both replace the previous `drm_bridge_put()` + explicit `= NULL` pattern.

- **Correctness**: The blank line removal in the error path (between the put and the `if` check) is a minor style change bundled in. This is fine but worth noting.

- **Reviewed-by tag present**: Already has a Reviewed-by from Osama Abdelkader.

- **No functional change** beyond the ordering of NULL-assignment vs put, which is the whole point.

Overall: a clean, low-risk series. The main actionable feedback is whether `WRITE_ONCE` should be used in patch 1 to actually deliver on the stated concurrency safety promise.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-11  3:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 12:13 [PATCH v2 0/2] drm/bridge: add drm_bridge_clear_and_put() Luca Ceresoli
2026-03-10 12:13 ` [PATCH v2 1/2] " Luca Ceresoli
2026-03-11  3:16   ` Claude review: " Claude Code Review Bot
2026-03-10 12:13 ` [PATCH v2 2/2] drm/bridge: samsung-dsim: use drm_bridge_clear_and_put() to put the next bridge Luca Ceresoli
2026-03-11  3:16   ` Claude Code Review Bot [this message]
2026-03-11  3:16 ` Claude review: drm/bridge: add drm_bridge_clear_and_put() Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260310-drm-bridge-atomic-vs-remove-clear_and_put-v2-2-51fe222f3cf0@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox