public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: panel-simple-dsi: add nt37700f compatible
Date: Tue, 10 Mar 2026 11:42:23 +1000	[thread overview]
Message-ID: <review-patch2-20260310002606.16413-3-mailingradian@gmail.com> (raw)
In-Reply-To: <20260310002606.16413-3-mailingradian@gmail.com>

Patch Review

**Status: Questionable — potential conflict with patch 3.**

This adds `novatek,nt37700f` to `panel-simple-dsi.yaml`:

```
+        # Novatek NT37700F 1080x2160 AMOLED panel
+      - novatek,nt37700f
```

However, patch 3 adds a **dedicated panel driver** (`panel-novatek-nt37700f.c`), not a `panel-simple` entry. The `panel-simple-dsi.yaml` binding describes panels that only need a single `power-supply`, a backlight, and an enable GPIO — with no init sequences. The NT37700F driver has an extensive DSI init sequence (`nt37700f_tianma_on()`), page-switching commands, and custom backlight handling, which makes it clearly *not* a "simple" panel.

Adding the compatible to `panel-simple-dsi.yaml` while also having a dedicated driver could cause DT validation confusion. Typically, panels with dedicated drivers get their own binding YAML file (or are documented in the driver's own binding). Unless this is intentionally done so the panel can fall back to `panel-simple` without init commands (e.g., if the bootloader already initializes it), this seems like a mistake. The binding should probably be a standalone `novatek,nt37700f.yaml` instead.

That said, I notice this already has an ack from Krzysztof, so perhaps this is intentional for this use case, but it's worth clarifying.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-10  1:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10  0:26 [PATCH v3 0/5] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-03-10  0:26 ` [PATCH v3 1/5] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  0:26 ` [PATCH v3 2/5] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-03-10  1:42   ` Claude Code Review Bot [this message]
2026-03-10  0:26 ` [PATCH v3 3/5] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  0:26 ` [PATCH v3 4/5] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  0:26 ` [PATCH v3 5/5] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-03-10  1:42   ` Claude review: " Claude Code Review Bot
2026-03-10  1:42 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-02-17  0:08 [PATCH v2 0/6] " Richard Acayan
2026-02-17  0:08 ` [PATCH v2 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-17  5:51   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:32 ` [PATCH 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260310002606.16413-3-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox