From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use Date: Tue, 10 Mar 2026 11:39:06 +1000 Message-ID: In-Reply-To: <20260310012458.169272-3-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> <20260310012458.169272-3-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves `imx-legacy-bridge.c` to `drivers/gpu/drm/bridge/of-display-mode-bridge.c` and renames all types/functions accordingly. The header moves from `include/drm/bridge/imx.h` to `include/drm/bridge/of-display-mode-bridge.h`. Kconfig/Makefile updates are correct. Minor note: `of_display_mode_bridge_funcs` at line 568 of the new file is not declared `static`: ```c struct drm_bridge_funcs of_display_mode_bridge_funcs = { ``` This should be `static const struct drm_bridge_funcs`. The original `imx_legacy_bridge_funcs` had the same issue, but this would be a good time to fix it. --- Generated by Claude Code Patch Reviewer