From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation and mapping Date: Wed, 11 Mar 2026 13:48:35 +1000 Message-ID: In-Reply-To: <20260310032012.2542334-3-wenst@chromium.org> References: <20260310032012.2542334-1-wenst@chromium.org> <20260310032012.2542334-3-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Mechanically replaces all `drm->dev` / `gem_obj->dev->dev` with `drm_dev_dma_dev(drm)` / `drm_dev_dma_dev(gem_obj->dev)` in the GEM DMA helper for allocation, free, sgtable, and mmap paths. The changes are consistent and complete -- all DMA API calls in `drm_gem_dma_helper.c` now go through `drm_dev_dma_dev()`: - `dma_alloc_noncoherent()` / `dma_alloc_wc()` in `drm_gem_dma_create()` - `dma_free_noncoherent()` / `dma_free_wc()` in `drm_gem_dma_free()` - `dma_get_sgtable()` in `drm_gem_dma_get_sg_table()` - `dma_mmap_pages()` / `dma_mmap_wc()` in `drm_gem_dma_mmap()` The commit message correctly notes no existing driver currently combines GEM DMA helpers with `drm_dev_set_dma_dev()`, so this is safe to land without immediate behavioral changes. **Reviewed-by worthy**: Yes. --- Generated by Claude Code Patch Reviewer