From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation and mapping Date: Wed, 11 Mar 2026 13:45:58 +1000 Message-ID: In-Reply-To: <20260310032511.2545500-3-wenst@chromium.org> References: <20260310032511.2545500-1-wenst@chromium.org> <20260310032511.2545500-3-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This patch systematically replaces `drm->dev` / `gem_obj->dev->dev` with `drm_dev_dma_dev(drm)` / `drm_dev_dma_dev(gem_obj->dev)` in five locations across `drm_gem_dma_helper.c`: 1. `dma_alloc_noncoherent()` in `drm_gem_dma_create()` 2. `dma_alloc_wc()` in `drm_gem_dma_create()` 3. `dma_free_noncoherent()` in `drm_gem_dma_free()` 4. `dma_free_wc()` in `drm_gem_dma_free()` 5. `dma_get_sgtable()` in `drm_gem_dma_get_sg_table()` 6. `dma_mmap_pages()` in `drm_gem_dma_mmap()` 7. `dma_mmap_wc()` in `drm_gem_dma_mmap()` All changes are consistent and correct. The commit message correctly notes that no existing driver currently combines GEM DMA helpers with `drm_dev_set_dma_dev()`, so existing users are unaffected. No issues with this patch. --- Generated by Claude Code Patch Reviewer