From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur CDSP Date: Wed, 11 Mar 2026 13:43:35 +1000 Message-ID: In-Reply-To: <20260310033617.3108675-3-sibi.sankar@oss.qualcomm.com> References: <20260310033617.3108675-1-sibi.sankar@oss.qualcomm.com> <20260310033617.3108675-3-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Looks correct.** Adds `qcom,glymur-cdsp-pas` falling back to `qcom,sm8550= -cdsp-pas`, and adds it to the same `allOf` `contains` block as the ADSP. One observation: The Glymur CDSP in patch 4 has 6 interrupts (including "sh= utdown-ack") and 2 memory regions. The `allOf` block this is added to (alon= gside `qcom,kaanapali-adsp-pas`, `qcom,kaanapali-cdsp-pas`, `qcom,sm8750-ad= sp-pas`) should constrain interrupts to 6 and memory to 2 =E2=80=94 which m= atches. This is fine assuming that block is the correct one for the combine= d ADSP/CDSP Kaanapali-family constraints. No issues found. --- Generated by Claude Code Patch Reviewer