Claude review: drm/atomic: Add affected colorops with affected planes

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Verdict: Mostly good, one concern.**

The change adds colorops to the atomic state when `drm_atomic_add_affected_planes()` pulls in a plane:

```c
+		if (plane_state->color_pipeline) {
+			ret = drm_atomic_add_affected_colorops(state, plane);
+			if (ret)
+				return ret;
+		}
```

The guard on `plane_state->color_pipeline` (added in v2) is a reasonable optimization to avoid pulling in colorop state when no pipeline is active, keeping the atomic state small for the common case.

**Concern about which state is checked:** `plane_state` here is the return value of `drm_atomic_get_plane_state()`, which returns the **new** (duplicated) plane state. Since `__drm_atomic_helper_plane_duplicate_state()` preserves `color_pipeline` via `memcpy()`, this correctly reflects the committed hardware state. This is fine.

**Minor concern — should this be unconditional?** The `color_pipeline` check means that if a plane's pipeline was *just disabled* in the same transaction (e.g., userspace set `COLOR_PIPELINE` to NULL in this commit), the colorops won't be pulled in. In theory this could matter if the driver needs to see the colorop state transition from active→bypass. However, since `drm_atomic_add_affected_planes()` operates on the *old* crtc state's plane mask (planes that were enabled before this commit), and the plane state here is the duplicated (pre-commit) state, `color_pipeline` should still reflect the old active pipeline. So this should be fine in practice.

**The `Reviewed-by: Uma Shankar` tag says `#v1`** — this was reviewed on v1 but v2 added the `color_pipeline` guard. The tag should ideally be re-confirmed for v2 since the logic changed (previously it would unconditionally add colorops, now it's conditional).

**Overall:** Both patches are correct and well-scoped fixes for a real bug. The series is suitable for merging and stable backport.

---
Generated by Claude Code Patch Reviewer