From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi: Avoid double error print on msm_hdmi_get_phy() failure Date: Thu, 12 Mar 2026 06:45:26 +1000 Message-ID: In-Reply-To: <20260311-drm-msm-hdmi-cleanup-v1-2-c5535245f6de@oss.qualcomm.com> References: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> <20260311-drm-msm-hdmi-cleanup-v1-2-c5535245f6de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Correct. Looking at `msm_hdmi_get_phy()` (hdmi.c:88-115), every error path = already prints via `DRM_DEV_ERROR` or `dev_err_probe()`, so the caller's `D= RM_DEV_ERROR("failed to get phy\n")` was indeed redundant. Additionally, `d= ev_err_probe()` with `-EPROBE_DEFER` correctly suppresses the message durin= g deferred probing, while the removed `DRM_DEV_ERROR` would have printed un= conditionally =E2=80=94 so this also fixes a minor log spam issue. No issues. --- Generated by Claude Code Patch Reviewer