public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tidss: Fix missing drm_bridge_attach() call
Date: Thu, 12 Mar 2026 07:12:05 +1000	[thread overview]
Message-ID: <review-patch2-20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com> (raw)
In-Reply-To: <20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com>

Patch Review

**One issue:** The subject line says "Fix missing drm_bridge_attach() call" but the actual fix adds a `drm_bridge_add()` call. The subject should read **"Fix missing drm_bridge_add() call"**. The body text is correct.

**Missing error check:** `devm_drm_bridge_add()` returns `int` (0 on success, negative errno on failure). The patch does not check the return value:

```c
+	devm_drm_bridge_add(tidss->dev, &t_enc->bridge);
```

This should be:

```c
	ret = devm_drm_bridge_add(tidss->dev, &t_enc->bridge);
	if (ret)
		return ret;
```

The `ret` variable is already declared and available in scope at `tidss_encoder.c:91`.

The placement of the call (after `devm_drm_bridge_alloc()` and encoder init, but before `drm_bridge_attach()`) is correct — the bridge must be added to the global list before it can be attached.

The Fixes tag, Cc: stable annotation, and the thorough explanation of why the fix is only needed for v6.17+ are all well done.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-11 21:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  8:16 [PATCH 0/2] drm/tidss: Two minor fixes Tomi Valkeinen
2026-03-11  8:16 ` [PATCH 1/2] drm/tidss: Drop extra drm_mode_config_reset() call Tomi Valkeinen
2026-03-11  9:09   ` Maxime Ripard
2026-03-11 21:12   ` Claude review: " Claude Code Review Bot
2026-03-11  8:16 ` [PATCH 2/2] drm/tidss: Fix missing drm_bridge_attach() call Tomi Valkeinen
2026-03-11  9:08   ` Maxime Ripard
2026-03-11  9:15     ` Tomi Valkeinen
2026-03-11 21:12   ` Claude Code Review Bot [this message]
2026-03-11 21:12 ` Claude review: drm/tidss: Two minor fixes Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox