From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tidss: Fix missing drm_bridge_attach() call Date: Thu, 12 Mar 2026 07:12:05 +1000 Message-ID: In-Reply-To: <20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com> References: <20260311-tidss-minor-fixes-v1-0-ee5e6e14a566@ideasonboard.com> <20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **One issue:** The subject line says "Fix missing drm_bridge_attach() call"= but the actual fix adds a `drm_bridge_add()` call. The subject should read= **"Fix missing drm_bridge_add() call"**. The body text is correct. **Missing error check:** `devm_drm_bridge_add()` returns `int` (0 on succes= s, negative errno on failure). The patch does not check the return value: ```c + devm_drm_bridge_add(tidss->dev, &t_enc->bridge); ``` This should be: ```c ret =3D devm_drm_bridge_add(tidss->dev, &t_enc->bridge); if (ret) return ret; ``` The `ret` variable is already declared and available in scope at `tidss_enc= oder.c:91`. The placement of the call (after `devm_drm_bridge_alloc()` and encoder init= , but before `drm_bridge_attach()`) is correct =E2=80=94 the bridge must be= added to the global list before it can be attached. The Fixes tag, Cc: stable annotation, and the thorough explanation of why t= he fix is only needed for v6.17+ are all well done. --- Generated by Claude Code Patch Reviewer