public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tidss: Fix missing drm_bridge_add() call
Date: Thu, 12 Mar 2026 07:10:40 +1000	[thread overview]
Message-ID: <review-patch2-20260311-tidss-minor-fixes-v2-2-cb4479784458@ideasonboard.com> (raw)
In-Reply-To: <20260311-tidss-minor-fixes-v2-2-cb4479784458@ideasonboard.com>

Patch Review

**Status: Minor issue — missing return value check.**

The fix correctly adds `devm_drm_bridge_add()` before the `drm_bridge_attach()` call, which resolves the "Missing drm_bridge_add() before attach" warning. The placement at line 108 (after setting `possible_crtcs`, before attaching) is correct.

The commit message is excellent — it carefully documents why the Fixes tag references one commit but a stable backport to pre-v6.17 would need different code, and why the bug hasn't caused real issues despite being present since v6.6.

**Issue: `devm_drm_bridge_add()` returns `int` and can fail** (it calls `devm_add_action_or_reset()` internally), but the return value is not checked:

```c
+	devm_drm_bridge_add(tidss->dev, &t_enc->bridge);
```

Other callers in the tree check this return value (e.g., `msm/hdmi/hdmi_bridge.c`). This should be:

```c
	ret = devm_drm_bridge_add(tidss->dev, &t_enc->bridge);
	if (ret)
		return ret;
```

While the failure mode (OOM from `devm_add_action_or_reset`) is unlikely, it's good practice to propagate the error, especially since the function already has `ret` declared and returns errors from other calls on the same path.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-11 21:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  9:14 [PATCH v2 0/2] drm/tidss: Two minor fixes Tomi Valkeinen
2026-03-11  9:14 ` [PATCH v2 1/2] drm/tidss: Drop extra drm_mode_config_reset() call Tomi Valkeinen
2026-03-11 21:10   ` Claude review: " Claude Code Review Bot
2026-03-11  9:14 ` [PATCH v2 2/2] drm/tidss: Fix missing drm_bridge_add() call Tomi Valkeinen
2026-03-11 21:10   ` Claude Code Review Bot [this message]
2026-03-11 21:10 ` Claude review: drm/tidss: Two minor fixes Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260311-tidss-minor-fixes-v2-2-cb4479784458@ideasonboard.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox