From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation and mapping
Date: Thu, 12 Mar 2026 07:08:42 +1000 [thread overview]
Message-ID: <review-patch2-20260311094929.3393338-3-wenst@chromium.org> (raw)
In-Reply-To: <20260311094929.3393338-3-wenst@chromium.org>
Patch Review
This patch consistently replaces `drm->dev` / `gem_obj->dev->dev` / `dma_obj->base.dev->dev` with the corresponding `drm_dev_dma_dev()` call across all DMA operations in the GEM DMA helpers: `dma_alloc_noncoherent`, `dma_alloc_wc`, `dma_free_noncoherent`, `dma_free_wc`, `dma_get_sgtable`, `dma_mmap_pages`, and `dma_mmap_wc`.
The changes are mechanical and correct. The allocation and free paths are matched — both use the same device accessor, ensuring no mismatch between the device used for allocation vs. free. The commit message correctly notes that no existing driver currently combines GEM DMA helpers with `drm_dev_set_dma_dev()`, so this is purely laying groundwork.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 9:49 [PATCH v2 0/4] drm/gem-dma: Support dedicated DMA device for allocation Chen-Yu Tsai
2026-03-11 9:49 ` [PATCH v2 1/4] drm/prime: Limit scatter list size with dedicated DMA device Chen-Yu Tsai
2026-03-11 14:40 ` AngeloGioacchino Del Regno
2026-03-11 21:08 ` Claude review: " Claude Code Review Bot
2026-03-11 9:49 ` [PATCH v2 2/4] drm/gem-dma: Support dedicated DMA device for allocation and mapping Chen-Yu Tsai
2026-03-11 14:40 ` AngeloGioacchino Del Regno
2026-03-11 21:08 ` Claude Code Review Bot [this message]
2026-03-11 9:49 ` [PATCH v2 3/4] drm/mediatek: Set dedicated DMA device and drop custom GEM callbacks Chen-Yu Tsai
2026-03-11 14:40 ` AngeloGioacchino Del Regno
2026-03-11 21:08 ` Claude review: " Claude Code Review Bot
2026-03-11 9:49 ` [PATCH v2 4/4] drm/sun4i: Use backend/mixer as dedicated DMA device Chen-Yu Tsai
2026-03-11 21:08 ` Claude review: " Claude Code Review Bot
2026-03-11 21:08 ` Claude review: drm/gem-dma: Support dedicated DMA device for allocation Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 3:25 [PATCH RESEND 0/4] " Chen-Yu Tsai
2026-03-10 3:25 ` [PATCH RESEND 2/4] drm/gem-dma: Support dedicated DMA device for allocation and mapping Chen-Yu Tsai
2026-03-11 3:45 ` Claude review: " Claude Code Review Bot
2026-03-10 3:20 [PATCH 0/4] drm/gem-dma: Support dedicated DMA device for allocation Chen-Yu Tsai
2026-03-10 3:20 ` [PATCH 2/4] drm/gem-dma: Support dedicated DMA device for allocation and mapping Chen-Yu Tsai
2026-03-11 3:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260311094929.3393338-3-wenst@chromium.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox