From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation and mapping Date: Thu, 12 Mar 2026 07:08:42 +1000 Message-ID: In-Reply-To: <20260311094929.3393338-3-wenst@chromium.org> References: <20260311094929.3393338-1-wenst@chromium.org> <20260311094929.3393338-3-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This patch consistently replaces `drm->dev` / `gem_obj->dev->dev` / `dma_ob= j->base.dev->dev` with the corresponding `drm_dev_dma_dev()` call across al= l DMA operations in the GEM DMA helpers: `dma_alloc_noncoherent`, `dma_allo= c_wc`, `dma_free_noncoherent`, `dma_free_wc`, `dma_get_sgtable`, `dma_mmap_= pages`, and `dma_mmap_wc`. The changes are mechanical and correct. The allocation and free paths are m= atched =E2=80=94 both use the same device accessor, ensuring no mismatch be= tween the device used for allocation vs. free. The commit message correctly= notes that no existing driver currently combines GEM DMA helpers with `drm= _dev_set_dma_dev()`, so this is purely laying groundwork. No issues. --- Generated by Claude Code Patch Reviewer