From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mipi-dbi: Support custom pipelines with drm_mipi_dbi_dev_init() Date: Thu, 12 Mar 2026 07:03:37 +1000 Message-ID: In-Reply-To: <20260311101438.365997-3-tzimmermann@suse.de> References: <20260311101438.365997-1-tzimmermann@suse.de> <20260311101438.365997-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Extracts device initialization (tx_buf allocation, mode/rotation/format setup) from `mipi_dbi_dev_init_with_formats()` into a new `drm_mipi_dbi_dev_init()` that does not create any KMS objects. This allows drivers to use the common init and then set up their own pipeline. The naming (`drm_mipi_dbi_dev_init` vs existing `mipi_dbi_dev_init`) is potentially confusing but the commit message explains the `drm_` prefix convention. The auto-calculation of `tx_buf_size` when zero is correct. No issues found. --- Generated by Claude Code Patch Reviewer