From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/dp: Clean up DPRX feature enumeration macros Date: Thu, 12 Mar 2026 06:55:28 +1000 Message-ID: In-Reply-To: <20260311113611.3393194-3-ankit.k.nautiyal@intel.com> References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-3-ankit.k.nautiyal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Converts open-coded `(1 << N)` to `BIT(N)` and aligns the indentation of the `DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1` macros. Cosmetic cleanup. **Minor nit:** The alignment results in very long lines for the `#define` of the register address itself: ```c #define DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1 0x2214 /* 2.0 E11 */ ``` This is significantly wider than surrounding definitions (e.g. `DP_128B132B_SUPPORTED_LINK_RATES` at line 370 still uses the old style). Inconsistency with surrounding code, but not a blocker. --- Generated by Claude Code Patch Reviewer