public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: talos: Add gpu and rgmu nodes
Date: Fri, 13 Mar 2026 14:34:42 +1000	[thread overview]
Message-ID: <review-patch2-20260312-qcs615-spin-2-v8-2-fca38edcd6e6@oss.qualcomm.com> (raw)
In-Reply-To: <20260312-qcs615-spin-2-v8-2-fca38edcd6e6@oss.qualcomm.com>

Patch Review

**Issue: GMU node unit address mismatch.**

The node name is `gmu@506a000` but the `reg` property starts at `0x0506d000`:

```dts
gmu: gmu@506a000 {
    compatible = "qcom,adreno-rgmu-612.0", "qcom,adreno-rgmu";
    reg = <0x0 0x0506d000 0x0 0x2c000>;
```

Per DT conventions, the unit address in the node name must match the first address in the `reg` property. This should be `gmu@506d000`. For comparison, the full GMU on SDM845 uses `gmu@506a000` with `reg = <0 0x0506a000 ...>` — matching correctly. The RGMU on this SoC starts at a different offset and the node name must reflect that. This will likely trigger a `dtbs_check` warning (`node name unit address does not match first reg entry`).

Note: The binding document example (`qcom,adreno-rgmu.yaml` line 90–93) itself has a mismatch (`gmu@506a000` with `reg = <0x05000000 0x90000>`) — that's a pre-existing issue in the binding doc, not introduced by this series, but worth fixing as a follow-up.

**Rest of patch 2 looks good:**
- The `pil_gpu_mem` reserved memory region at `0x97715000` with size `0x2000` and `no-map` is standard for GPU firmware.
- The GPU node at `gpu@5000000` follows the established A6xx pattern with correct `reg-names` (`kgsl_3d0_reg_memory`, `cx_mem`, `cx_dbgc`).
- OPP table has 5 entries (435–845 MHz) with correct power domain / bandwidth pairings.
- `power-domains = <&rpmhpd RPMHPD_CX>` is correct for 6xx-gen1 GPUs.
- `#cooling-cells = <2>` is added here, enabling the thermal binding in patch 3.
- `status = "disabled"` is correct for an SoC-level dtsi — enablement comes per-board.
- GMU clocks and power domains match the RGMU binding schema.
- Address ordering (gpu, gmu, gpucc, smmu) is correct within the SoC node.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13  4:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 23:09 [PATCH v8 0/4] Support for Adreno 612 GPU - Respin Akhil P Oommen
2026-03-11 23:09 ` [PATCH v8 1/4] arm64: dts: qcom: talos: add the GPU SMMU node Akhil P Oommen
2026-03-13  4:34   ` Claude review: " Claude Code Review Bot
2026-03-11 23:09 ` [PATCH v8 2/4] arm64: dts: qcom: talos: Add gpu and rgmu nodes Akhil P Oommen
2026-03-13  4:34   ` Claude Code Review Bot [this message]
2026-03-11 23:09 ` [PATCH v8 3/4] arm64: dts: qcom: talos: Add GPU cooling Akhil P Oommen
2026-03-13  4:34   ` Claude review: " Claude Code Review Bot
2026-03-11 23:09 ` [PATCH v8 4/4] arm64: dts: qcom: qcs615-ride: Enable Adreno 612 GPU Akhil P Oommen
2026-03-13  4:34   ` Claude review: " Claude Code Review Bot
2026-03-13  4:34 ` Claude review: Support for Adreno 612 GPU - Respin Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260312-qcs615-spin-2-v8-2-fca38edcd6e6@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox