From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/pagemap: Add helper to access zone_device_data
Date: Fri, 13 Mar 2026 13:55:14 +1000 [thread overview]
Message-ID: <review-patch2-20260312192126.2024853-3-francois.dugast@intel.com> (raw)
In-Reply-To: <20260312192126.2024853-3-francois.dugast@intel.com>
Patch Review
**Good:** Centralizes `zone_device_data` access through `drm_pagemap_page_zone_device_data()`, which correctly goes through the folio API (`page_folio()` → `folio_zone_device_data()`). This prepares for THP where only the head page's `zone_device_data` is meaningful.
**Concern — `folio_zone_device_data` only checks `folio_is_device_private`:**
Looking at the kernel's `folio_zone_device_data()`:
```c
static inline void *folio_zone_device_data(const struct folio *folio)
{
VM_WARN_ON_FOLIO(!folio_is_device_private(folio), folio);
return folio->page.zone_device_data;
}
```
This will trigger a `VM_WARN` if called on a device-coherent folio. The existing code in `drm_pagemap.c` accesses `zone_device_data` on both device-private and device-coherent pages (e.g., `drm_pagemap_migrate_unmap_pages` checks `is_zone_device_page` which covers both). In `drm_gpusvm.c` the call site at line 1493 also checks `is_device_coherent_page`. So the new helper will produce `VM_WARN` on coherent pages in debug builds. This seems like a pre-existing issue with the `folio_zone_device_data` API rather than this patch specifically, but it's worth noting — the callers in `drm_pagemap_migrate_unmap_pages` at line 325-326 use `is_zone_device_page` which includes coherent pages.
**Good:** The `#else` stub returning NULL for `!CONFIG_ZONE_DEVICE` is correctly placed (the v9 changelog notes this was a build fix).
**Minor:** In `drm_pagemap_folio_free`:
```c
struct page *page = folio_page(folio, 0);
drm_pagemap_zdd_put(drm_pagemap_page_zone_device_data(page));
```
This could simply use `folio_zone_device_data(folio)` directly without the extra `folio_page` + `page_folio` round-trip inside the helper. Not a bug, just a minor indirection.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 3:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 19:20 [PATCH v9 0/4] Enable THP support in drm_pagemap Francois Dugast
2026-03-12 19:20 ` [PATCH v9 1/4] drm/pagemap: Unlock and put folios when possible Francois Dugast
2026-03-13 3:55 ` Claude review: " Claude Code Review Bot
2026-03-12 19:20 ` [PATCH v9 2/4] drm/pagemap: Add helper to access zone_device_data Francois Dugast
2026-03-13 3:55 ` Claude Code Review Bot [this message]
2026-03-12 19:20 ` [PATCH v9 3/4] drm/pagemap: Correct cpages calculation for migrate_vma_setup Francois Dugast
2026-03-13 3:55 ` Claude review: " Claude Code Review Bot
2026-03-12 19:20 ` [PATCH v9 4/4] drm/pagemap: Enable THP support for GPU memory migration Francois Dugast
2026-03-13 3:55 ` Claude review: " Claude Code Review Bot
2026-03-13 3:55 ` Claude review: Enable THP support in drm_pagemap Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-12 15:16 [PATCH v8 0/4] " Francois Dugast
2026-03-12 15:16 ` [PATCH v8 2/4] drm/pagemap: Add helper to access zone_device_data Francois Dugast
2026-03-13 4:02 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260312192126.2024853-3-francois.dugast@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox