public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Skip 2nd thread DM association for non META Firmware
Date: Sat, 14 Mar 2026 07:22:40 +1000	[thread overview]
Message-ID: <review-patch2-20260313-b4-staging-layout_mars_base-v2-2-9e3c251d278e@imgtec.com> (raw)
In-Reply-To: <20260313-b4-staging-layout_mars_base-v2-2-9e3c251d278e@imgtec.com>

Patch Review

**Logic:**

Correct. Only META firmware processors have two threads, so the Thread1 DM association writes should be skipped for RISC-V (and any other non-META) firmware. The `meta_fw` variable was already introduced in patch 1, so this uses it cleanly.

**Indentation issue:**

```c
	if (meta_fw) {
		pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC,
			   ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC_MASKFULL &
			   ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC_DM_ASSOC_CLRMSK);
		pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_BGCTX_THREAD1_DM_ASSOC,
			   ROGUE_CR_MTS_BGCTX_THREAD1_DM_ASSOC_MASKFULL &
			   ROGUE_CR_MTS_BGCTX_THREAD1_DM_ASSOC_DM_ASSOC_CLRMSK);
	}
```

The continuation lines for the `pvr_cr_write32` arguments are indented with spaces to align to column position, but they don't match the surrounding code's alignment style. Before this patch, these same lines used tab+spaces to align the arguments under the opening parenthesis. After the patch, the arguments are indented less (3 tabs + 3 spaces) instead of matching the opening paren position. Compare with the Thread0 writes just above which use proper alignment. This should be fixed for consistency.

**Overall:** Both patches are straightforward and correct in intent. The main actionable items are:
1. Explain (in commit message or comment) why the early SLC idle check was added for non-MARS configs in patch 1.
2. Fix the alignment/indentation issues in both patches.
3. Fix the missing period in the multi-line comment and the stray blank line in patch 1.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  6:38 [PATCH v2 0/2] drm/imagination: Improve power off sequence Brajesh Gupta
2026-03-13  6:38 ` [PATCH v2 1/2] drm/imagination: Improve firmware power off for layout_mars config Brajesh Gupta
2026-03-13 21:22   ` Claude review: " Claude Code Review Bot
2026-03-13  6:38 ` [PATCH v2 2/2] drm/imagination: Skip 2nd thread DM association for non META Firmware Brajesh Gupta
2026-03-13 21:22   ` Claude Code Review Bot [this message]
2026-03-13 21:22 ` Claude review: drm/imagination: Improve power off sequence Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260313-b4-staging-layout_mars_base-v2-2-9e3c251d278e@imgtec.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox