From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Skip 2nd thread DM association for non META Firmware Date: Sat, 14 Mar 2026 07:22:40 +1000 Message-ID: In-Reply-To: <20260313-b4-staging-layout_mars_base-v2-2-9e3c251d278e@imgtec.com> References: <20260313-b4-staging-layout_mars_base-v2-0-9e3c251d278e@imgtec.com> <20260313-b4-staging-layout_mars_base-v2-2-9e3c251d278e@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Logic:** Correct. Only META firmware processors have two threads, so the Thread1 DM association writes should be skipped for RISC-V (and any other non-META) firmware. The `meta_fw` variable was already introduced in patch 1, so this uses it cleanly. **Indentation issue:** ```c if (meta_fw) { pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC, ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC_MASKFULL & ROGUE_CR_MTS_INTCTX_THREAD1_DM_ASSOC_DM_ASSOC_CLRMSK); pvr_cr_write32(pvr_dev, ROGUE_CR_MTS_BGCTX_THREAD1_DM_ASSOC, ROGUE_CR_MTS_BGCTX_THREAD1_DM_ASSOC_MASKFULL & ROGUE_CR_MTS_BGCTX_THREAD1_DM_ASSOC_DM_ASSOC_CLRMSK); } ``` The continuation lines for the `pvr_cr_write32` arguments are indented with spaces to align to column position, but they don't match the surrounding code's alignment style. Before this patch, these same lines used tab+spaces to align the arguments under the opening parenthesis. After the patch, the arguments are indented less (3 tabs + 3 spaces) instead of matching the opening paren position. Compare with the Thread0 writes just above which use proper alignment. This should be fixed for consistency. **Overall:** Both patches are straightforward and correct in intent. The main actionable items are: 1. Explain (in commit message or comment) why the early SLC idle check was added for non-MARS configs in patch 1. 2. Fix the alignment/indentation issues in both patches. 3. Fix the missing period in the multi-line comment and the stray blank line in patch 1. --- Generated by Claude Code Patch Reviewer