public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper
Date: Sat, 14 Mar 2026 07:10:15 +1000	[thread overview]
Message-ID: <review-patch2-20260313-dmemcg-aggressive-protect-v6-2-7c71cc1492db@gmx.de> (raw)
In-Reply-To: <20260313-dmemcg-aggressive-protect-v6-2-7c71cc1492db@gmx.de>

Patch Review

Adds `cgroup_common_ancestor()` to `include/linux/cgroup.h` and `dmem_cgroup_get_common_ancestor()` to dmem.

The `cgroup_common_ancestor()` implementation is clean — walks from `min(a->level, b->level)` downward checking `ancestors[]`. This is correct since two cgroups in the same hierarchy share ancestors at every level up to and including their LCA.

**Doc typo in `dmem_cgroup_get_common_ancestor()`**:
```
 * @b: First pool to find the common ancestor of.
```
Should say `@b: Second pool...`.

**Potential concern**: `dmem_cgroup_get_common_ancestor()` calls `cgroup_e_css()` and then `get_cg_pool_unlocked()`. The `cgroup_e_css()` call is done without holding `rcu_read_lock()`. Looking at the kernel, `cgroup_e_css()` dereferences `cgroup->subsys[]` which is RCU-protected. This should be called under `rcu_read_lock()`, or the caller should hold a reference that prevents the css from going away. The css obtained from `cgroup_e_css()` is passed to `css_to_dmemcs()` and then to `get_cg_pool_unlocked()` — if the css could be freed between these calls, this is a use-after-free. This warrants investigation: does the fact that `a` and `b` are alive (and hold references to their respective css) guarantee that the common ancestor's css is also alive? In cgroup v2 with a unified hierarchy this should be the case since parents can't be destroyed while children exist, but this should be documented or protected with `rcu_read_lock()` + `css_get()`.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13 21:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 11:39 [PATCH v6 0/6] cgroup/dmem,drm/ttm: Improve protection in contended cases Natalie Vock
2026-03-13 11:40 ` [PATCH v6 1/6] cgroup/dmem: Add queries for protection values Natalie Vock
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-13 14:16   ` Michal Koutný
2026-03-13 21:10   ` Claude Code Review Bot [this message]
2026-03-13 11:40 ` [PATCH v6 3/6] drm/ttm: Extract code for attempting allocation in a place Natalie Vock
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 4/6] drm/ttm: Split cgroup charge and resource allocation Natalie Vock
2026-03-13 12:53   ` Tvrtko Ursulin
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 5/6] drm/ttm: Be more aggressive when allocating below protection limit Natalie Vock
2026-03-13 13:29   ` Tvrtko Ursulin
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 11:40 ` [PATCH v6 6/6] drm/ttm: Use common ancestor of evictor and evictee as limit pool Natalie Vock
2026-03-13 14:11   ` Tvrtko Ursulin
2026-03-13 14:16   ` Michal Koutný
2026-03-13 21:10   ` Claude review: " Claude Code Review Bot
2026-03-13 21:10 ` Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-02 12:37 [PATCH v5 0/6] " Natalie Vock
2026-03-02 12:37 ` [PATCH v5 2/6] cgroup,cgroup/dmem: Add (dmem_)cgroup_common_ancestor helper Natalie Vock
2026-03-03  3:29   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260313-dmemcg-aggressive-protect-v6-2-7c71cc1492db@gmx.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox