From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: arm, komeda: add Arm China Linlon D6 compatible
Date: Sat, 14 Mar 2026 07:31:00 +1000 [thread overview]
Message-ID: <review-patch2-20260313033119.33686-3-cunyuan.liu@cixtech.com> (raw)
In-Reply-To: <20260313033119.33686-3-cunyuan.liu@cixtech.com>
Patch Review
Adds `armchina,linlon-d6` as a new compatible string with `arm,mali-d71` as the required fallback. The v2 rework correctly uses `enum` instead of the previous approach (as suggested by Krzysztof):
```yaml
- items:
- - const: arm,mali-d32
+ - enum:
+ - arm,mali-d32
+ - armchina,linlon-d6
- const: arm,mali-d71
```
This is the correct DT binding pattern — the Linlon-D6 must be described with `compatible = "armchina,linlon-d6", "arm,mali-d71"` in the device tree, which the schema now validates. The `arm,mali-d32` case is also properly folded into the same `enum` to keep the schema clean.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 21:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 3:31 [PATCH v2 0/3] Arm China Linlon-D6 display controller support Cunyuan Liu
2026-03-13 3:31 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Arm Technology (China) Co., Ltd Cunyuan Liu
2026-03-13 21:30 ` Claude review: " Claude Code Review Bot
2026-03-13 3:31 ` [PATCH v2 2/3] dt-bindings: display: arm, komeda: add Arm China Linlon D6 compatible Cunyuan Liu
2026-03-13 21:31 ` Claude Code Review Bot [this message]
2026-03-13 3:31 ` [PATCH v2 3/3] drm/komeda: Add support for Arm China Linlon-D6 Cunyuan Liu
2026-03-13 21:31 ` Claude review: " Claude Code Review Bot
2026-03-13 21:30 ` Claude review: Arm China Linlon-D6 display controller support Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-11 5:55 [PATCH 0/3] " Cunyuan Liu
2026-03-11 5:55 ` [PATCH 2/3] dt-bindings: display: arm, komeda: add Arm China Linlon D6 compatible Cunyuan Liu
2026-03-11 21:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260313033119.33686-3-cunyuan.liu@cixtech.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox