From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: remoteproc: qcom, sm8550-pas: Add Glymur CDSP Date: Sat, 14 Mar 2026 07:07:32 +1000 Message-ID: In-Reply-To: <20260313120814.1312410-3-sibi.sankar@oss.qualcomm.com> References: <20260313120814.1312410-1-sibi.sankar@oss.qualcomm.com> <20260313120814.1312410-3-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `qcom,glymur-cdsp-pas` to the sm8550-pas binding with fallback to `qcom,sm8550-cdsp-pas`. The compatible is added to: 1. The items group for CDSP with sm8550 fallback: ```yaml - qcom,glymur-cdsp-pas - qcom,kaanapali-cdsp-pas - const: qcom,sm8550-cdsp-pas ``` 2. The allOf conditional for 6 interrupts (same section as patch 1). Note that Glymur CDSP falls back to `sm8550-cdsp-pas` (not `sm8650-cdsp-pas` like SM8750 CDSP does). This is a meaningful distinction from SM8750 CDSP and the commit message correctly captures this: "compatible with SM8550 SoC except for the one additional interrupt." No issues. --- Generated by Claude Code Patch Reviewer