public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/psr: Disable Panel Replay on DP_DPCD_QUIRK_NO_PANEL_REPLAY quirk
Date: Sat, 14 Mar 2026 07:04:35 +1000	[thread overview]
Message-ID: <review-patch2-20260313122145.1747175-3-jouni.hogander@intel.com> (raw)
In-Reply-To: <20260313122145.1747175-3-jouni.hogander@intel.com>

Patch Review

**Placement in `_panel_replay_init_dpcd` is correct.** The quirk check is placed early in the function, after the MST check but before reading the Panel Replay DPCD capabilities, which avoids unnecessary DPCD reads:

```c
if (drm_dp_has_quirk(&intel_dp->desc, DP_DPCD_QUIRK_NO_PANEL_REPLAY)) {
    drm_dbg_kms(display->drm,
               "Panel Replay support not currently available for this panel\n");
    return;
}
```

This follows the same pattern as `DP_DPCD_QUIRK_NO_PSR` usage in `_psr_init_dpcd`.

**No issues with this patch itself.** The implementation is clean and correct. `intel_dp->desc` is populated by `drm_dp_read_desc()` before `_panel_replay_init_dpcd` is called, so the quirk data will be available.

**Summary:** The series is functionally correct and follows existing patterns well. The main concern is whether `DEVICE_ID_ANY` is intentional or if a specific device ID should be used to avoid disabling Panel Replay on all LG Display panels. The author should clarify whether all LG panels are affected or just a specific model.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-03-13 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 12:21 [PATCH 0/2] Disable Panel Replay as quirk for LGD panel Jouni Högander
2026-03-13 12:21 ` [PATCH 1/2] drm/dp: Add quirk to disable Panel Replay on certain panels Jouni Högander
2026-03-13 21:04   ` Claude review: " Claude Code Review Bot
2026-03-13 12:21 ` [PATCH 2/2] drm/i915/psr: Disable Panel Replay on DP_DPCD_QUIRK_NO_PANEL_REPLAY quirk Jouni Högander
2026-03-13 21:04   ` Claude Code Review Bot [this message]
2026-03-13 21:04 ` Claude review: Disable Panel Replay as quirk for LGD panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260313122145.1747175-3-jouni.hogander@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox