From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/psr: Disable Panel Replay on DP_DPCD_QUIRK_NO_PANEL_REPLAY quirk
Date: Sat, 14 Mar 2026 07:04:35 +1000
Message-ID: <review-patch2-20260313122145.1747175-3-jouni.hogander@intel.com>
In-Reply-To: <20260313122145.1747175-3-jouni.hogander@intel.com>
References: <20260313122145.1747175-1-jouni.hogander@intel.com> <20260313122145.1747175-3-jouni.hogander@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Placement in `_panel_replay_init_dpcd` is correct.** The quirk check is placed early in the function, after the MST check but before reading the Panel Replay DPCD capabilities, which avoids unnecessary DPCD reads:

```c
if (drm_dp_has_quirk(&intel_dp->desc, DP_DPCD_QUIRK_NO_PANEL_REPLAY)) {
    drm_dbg_kms(display->drm,
               "Panel Replay support not currently available for this panel\n");
    return;
}
```

This follows the same pattern as `DP_DPCD_QUIRK_NO_PSR` usage in `_psr_init_dpcd`.

**No issues with this patch itself.** The implementation is clean and correct. `intel_dp->desc` is populated by `drm_dp_read_desc()` before `_panel_replay_init_dpcd` is called, so the quirk data will be available.

**Summary:** The series is functionally correct and follows existing patterns well. The main concern is whether `DEVICE_ID_ANY` is intentional or if a specific device ID should be used to avoid disabling Panel Replay on all LG Display panels. The author should clarify whether all LG panels are affected or just a specific model.

---
Generated by Claude Code Patch Reviewer