Claude review: Re: [PATCH v3 2/4] serdev: add rust private data to serdev_device

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

```c
+	void *rust_private_data;
```

Adding a `void *` field to `struct serdev_device` purely for Rust abstraction use is somewhat controversial. This adds overhead to every `serdev_device` in the system, even when Rust is not used. 

**Concern:** Why not use the existing `dev_set_drvdata`/`dev_get_drvdata` mechanism for this? The patch series uses `dev_set_drvdata` for the driver's own data (`T`) and then needs this extra field for `PrivateData` (the completion/error pair). This suggests the abstraction design could be reworked to avoid needing two separate private data fields — for example, by wrapping the driver data and the completion together into a single struct stored via `dev_set_drvdata`.

The kdoc alignment changes are good cleanup (adding missing colons on `@write_comp:` and `@write_lock:`).

**Initialization concern:** The new `rust_private_data` field is never explicitly initialized in the C code that allocates `serdev_device`. It will be zero-initialized if the struct is allocated with `kzalloc`, but this should be documented or verified.

---
Generated by Claude Code Patch Reviewer